Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove aks-engine cluster in test matrix #779

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 31, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Remove aks-engine clusters in test matrix
  • Remove aks-engine cluster config
  • Update to v1.23.3 for kind tests

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #754

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #779 (7daad91) into master (e78f732) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   61.65%   61.65%           
=======================================
  Files           7        7           
  Lines         785      785           
=======================================
  Hits          484      484           
  Misses        267      267           
  Partials       34       34           

@aramase
Copy link
Member Author

aramase commented Jan 31, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@aramase
Copy link
Member Author

aramase commented Jan 31, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@aramase
Copy link
Member Author

aramase commented Jan 31, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase
Copy link
Member Author

aramase commented Jan 31, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase marked this pull request as ready for review January 31, 2022 23:10
@aramase aramase requested a review from nilekhc January 31, 2022 23:11
@nilekhc
Copy link
Contributor

nilekhc commented Feb 1, 2022

Could we also tests nightly pipeline to make sure all tests work?

@aramase
Copy link
Member Author

aramase commented Feb 1, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase
Copy link
Member Author

aramase commented Feb 1, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase force-pushed the remove-aks-engine branch 2 times, most recently from 7db6b08 to 7a5db87 Compare February 1, 2022 21:52
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase merged commit cdfff93 into Azure:master Feb 2, 2022
@aramase aramase deleted the remove-aks-engine branch February 2, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove aks-engine tests and template from PR and nightly runs
3 participants