Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix upgrade tests #800

Merged
merged 1 commit into from
Feb 23, 2022
Merged

test: fix upgrade tests #800

merged 1 commit into from
Feb 23, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 17, 2022

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@aramase
Copy link
Member Author

aramase commented Feb 17, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase force-pushed the fix-tests branch 5 times, most recently from a0bc071 to d7c25b9 Compare February 22, 2022 20:28
@aramase aramase marked this pull request as ready for review February 22, 2022 20:30
@aramase aramase requested a review from nilekhc February 22, 2022 20:30
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@@ -26,7 +26,7 @@ steps:

- script: |
#Run test with latest on preview aks version available
aksVersion=$(az aks get-versions -l $(AZURE_LOCATION) --query "max(orchestrators[?isPreview==null].orchestratorVersion)" -otsv)
aksVersion=$(az aks get-versions -l $(AZURE_LOCATION) --query "max(orchestrators[?isPreview==null&&orchestratorVersion>'1.20'].orchestratorVersion)" -otsv)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19 is no longer supported in AKS: https://docs.microsoft.com/en-us/azure/aks/supported-kubernetes-versions?tabs=azure-cli#aks-kubernetes-release-calendar. Adding the orchestratorVersion check here to make it more deterministic when picking the starting minor version.

Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase aramase merged commit 132553e into Azure:master Feb 23, 2022
@aramase aramase deleted the fix-tests branch February 23, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants