fix: update versions installed in devcontainer #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated versions: - golang base container updated to 1.17 - jq updated to 1.6 - helm updated to 3.7.0 - kind updated to 0.12.0 - kubectl updated to 1.22.2 This also removes a few packages that were installed and are currently marked as deprecated where the replacements are packages we're already installing: - gocode/gocod-mod is superseeded by gopls - gometalinter is superseeded by golangci-lint Additionally, golangci-lint is now installed via go install instead of curl-ing then sourcing the install script
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nilekhc
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated versions:
This also removes a few packages that were installed and are currently marked as deprecated where the replacements are packages we're already installing:
Additionally, golangci-lint is now installed via go install instead of curl-ing then sourcing the install script
Reason for Change:
When working on #834 I ran into some issues because the devcontainer was configured to use an older version of go than this project currently requires.
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:
I've verified this works as I expect it to on both windows and macOS, I do not have a linux dev machine but I wouldn't expect any of these changes to break on linux.