Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing chart version number in chart docs #845

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Conversation

jayar95
Copy link
Contributor

@jayar95 jayar95 commented Mar 28, 2022

Reason for Change:
Latest chart version is 1.1.1 not 1.1.0

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@jayar95 jayar95 changed the title Fixing chart version number in chart docs fix: Fixing chart version number in chart docs Mar 28, 2022
@jayar95
Copy link
Contributor Author

jayar95 commented Mar 28, 2022

found this while fixing #829 in a cluster

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Could you remove the changes from charts/ folder and instead update the helm chart README.md in the manifest_staging/charts folder, where we host the staging charts and deployment yamls. Any changes made in charts folder will trigger the action to repackage helm charts and I want to avoid building it for doc change. All the yaml and readme changes will be promoted into the released charts folder with the next release.

@jayar95 jayar95 requested a review from aramase March 29, 2022 15:07
@jayar95
Copy link
Contributor Author

jayar95 commented Mar 29, 2022

@aramase fixed 👍

@aramase aramase merged commit 21f8715 into Azure:master Mar 29, 2022
@sukhdeepsingh1
Copy link

@aramase @jayar95
Still do not see v1.1.1 in releases and in documentation, will it take time to formally release it?

@aramase
Copy link
Member

aramase commented Apr 22, 2022

@aramase @jayar95
Still do not see v1.1.1 in releases and in documentation, will it take time to formally release it?

@sukhdeepsingh1 All the charts are hosted in gh-pages: https://github.com/Azure/secrets-store-csi-driver-provider-azure/tree/gh-pages. Refer to the installation guide for the helm chart URL.

Also, there is no v1.1.1 release for the provider. There is v1.1.1 helm chart release and driver release.

@sukhdeepsingh1
Copy link

@aramase Ah, ok, thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants