Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change default to /var/run for provider path #859

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Apr 12, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

ref: kubernetes-sigs/secrets-store-csi-driver#823

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #859 (bf2ee79) into master (ff80a0f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   59.44%   59.44%           
=======================================
  Files           7        7           
  Lines         868      868           
=======================================
  Hits          516      516           
  Misses        316      316           
  Partials       36       36           

@aramase
Copy link
Member Author

aramase commented Apr 12, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase marked this pull request as ready for review April 12, 2022 18:26
@aramase aramase requested a review from nilekhc April 12, 2022 18:26
@aramase aramase merged commit 248d561 into Azure:master Apr 13, 2022
@aramase aramase deleted the change-provider-path branch April 13, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants