fix: updates arc ext check

[nilekhc]

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

Reason for Change:

Requirements

• squashed commits
• included documentation
• added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes: #892

Does this change contain code from or inspired by another project?

• Yes
• No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

[nilekhc]

/azp run pr-e2e-azure

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[nilekhc]

cc @vittoriocanilli

[vittoriocanilli]

LGTM.

I am not sure if you could have fixed it as well, by simply swapping the operators in the AND condition instead of having 2 nested IF statements.

Anyway I am not familiar with writing Helm charts 😄

[aramase]

Helm uses go template and the documentation (https://pkg.go.dev/text/template#hdr-Functions) does confirm that the arguments are evaluated from left to right. So if the first one is false, it should return false as the result is determined.

Could we switch the order like @vittoriocanilli suggested instead of nested ifs?

[netlify]

👷 Deploy request for secrets-store-csi-driver-provider-azure pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	637d767

[nilekhc]

Helm uses go template and the documentation (https://pkg.go.dev/text/template#hdr-Functions) does confirm that the arguments are evaluated from left to right. So if the first one is false, it should return false as the result is determined.

Could we switch the order like @vittoriocanilli suggested instead of nested ifs?

That's better. Thanks for the suggestion @vittoriocanilli

[codecov-commenter]

Codecov Report

Merging #893 (637d767) into master (9e590f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #893   +/-   ##
=======================================
  Coverage   59.79%   59.79%           
=======================================
  Files           7        7           
  Lines         868      868           
=======================================
  Hits          519      519           
  Misses        314      314           
  Partials       35       35           

[nilekhc]

/azp run pr-e2e-azure

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).