Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add additional logs in fetch cert chain #912

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 13, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Adds a warning log when the number of certs after reconstructing certificate chain is not equal to the number of certs from key vault.
    • This can be caused when the chain is incomplete

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #879

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase requested a review from nilekhc as a code owner June 13, 2022 17:41
@codecov-commenter
Copy link

Codecov Report

Merging #912 (c45dbbb) into master (1e5b425) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   61.26%   61.39%   +0.12%     
==========================================
  Files           8        8              
  Lines         901      904       +3     
==========================================
+ Hits          552      555       +3     
  Misses        314      314              
  Partials       35       35              

@aramase aramase merged commit cc6bb04 into Azure:master Jun 13, 2022
@aramase aramase deleted the add-logs branch June 13, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants