Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update validation and make it fail-fast #917

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 14, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Move validation a step before when deserializing the config from secret provider class
    • This helps avoid making additional key vault calls when there are errors in user-defined properties

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #917 (d68f4bd) into master (d90847c) will increase coverage by 0.76%.
The diff coverage is 79.22%.

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   61.39%   62.15%   +0.76%     
==========================================
  Files           8        9       +1     
  Lines         904      909       +5     
==========================================
+ Hits          555      565      +10     
+ Misses        314      311       -3     
+ Partials       35       33       -2     

@aramase aramase marked this pull request as ready for review June 14, 2022 23:28
@aramase aramase requested a review from nilekhc as a code owner June 14, 2022 23:28
@aramase
Copy link
Member Author

aramase commented Jun 14, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase merged commit 92fa62e into Azure:master Jun 17, 2022
@aramase aramase deleted the split-validation branch June 17, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants