Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix junit reporter filename #918

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 15, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Failed to create JUnit report file: /mnt/vss/_work/1/s/test/e2e
	open /mnt/vss/_work/1/s/test/e2e: is a directory
Failed to generate JUnit report data:
	invalid argument
  • Adds a filename for the junit report to be used by the reporter.
    • It fails now because JUNIT_OUTPUT_FILEPATH is a directory

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

Codecov Report

Merging #918 (dda93f3) into master (654b5c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   61.39%   61.39%           
=======================================
  Files           8        8           
  Lines         904      904           
=======================================
  Hits          555      555           
  Misses        314      314           
  Partials       35       35           

@aramase aramase marked this pull request as ready for review June 15, 2022 18:18
@aramase aramase requested a review from nilekhc as a code owner June 15, 2022 18:18
test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase merged commit d90847c into Azure:master Jun 15, 2022
@aramase aramase deleted the fix-junit-reporter branch June 15, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants