Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/BasisTheoryReact initializing multiple times when rerender #231

Conversation

talberkoMelio
Copy link

Description

BasisTheoryReact initializing multiple times when rerender.
This is because the initialization is async and can take time, and meanwhile the hook can trigger again.
The solution is to add isLoading indicator.

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@talberkoMelio talberkoMelio requested a review from a team as a code owner February 14, 2024 12:37
@talberkoMelio
Copy link
Author

Hi @kevinperaza
Can you please take a look? This is a major bug we hope will be fixed and released so we can update the package.

@djejaquino
Copy link
Contributor

#232 closes this

@djejaquino djejaquino closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants