Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Display Cards" Guide #134

Merged
merged 14 commits into from
Jun 12, 2023
Merged

Add "Display Cards" Guide #134

merged 14 commits into from
Jun 12, 2023

Conversation

djejaquino
Copy link
Contributor

@djejaquino djejaquino commented Jun 7, 2023 •
edited
Loading

Description

  • Adds Display Cards Guide
  • Breaks apart Collect Cards guide in 2: default (using multiple elements), and alternative version (using single card element)
  • Adds deduplication and CVC retention to Issue Cards guide
  • Upgrades dependencies

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@djejaquino djejaquino requested a review from a team as a code owner June 7, 2023 12:53
@vercel
Copy link

vercel bot commented Jun 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers-basistheory-com ✅ Ready (Inspect) Visit Preview ✅ 1 resolved Jun 12, 2023 3:43pm

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 7, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71ec7ee
Status: ✅  Deploy successful!
Preview URL: https://963d5bb0.developers-basistheory-com.pages.dev
Branch Preview URL: https://se-70.developers-basistheory-com.pages.dev

View logs

jleon15
jleon15 requested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@jleon15 jleon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice guides! left a few comments

@djejaquino djejaquino merged commit 82e5e23 into master Jun 12, 2023
3 checks passed
@djejaquino djejaquino deleted the se-70 branch June 12, 2023 20:52
bt-platform-eng pushed a commit that referenced this pull request Jun 12, 2023
@semantic-release-bot
chore(release): 1.56.0 [skip ci]
4bcd4fe 
# [1.56.0](v1.55.0...v1.56.0) (2023-06-12)

### Features

* Add "Display Cards" Guide ([#134](#134)) ([82e5e23](82e5e23))
@bt-platform-eng
Copy link

🎉 This PR is included in version 1.56.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcschy lcschy lcschy left review comments

@brigonzalez brigonzalez brigonzalez left review comments

@kevinperaza kevinperaza kevinperaza left review comments

@jleon15 jleon15 jleon15 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@djejaquino @bt-platform-eng @lcschy @brigonzalez @kevinperaza @jleon15