Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add step for enforcing https #345

Closed
wants to merge 1 commit into from
Closed

fix: add step for enforcing https #345

wants to merge 1 commit into from

Conversation

djejaquino
Copy link
Contributor

@djejaquino djejaquino commented Mar 7, 2024

Description

Custom hostnames only work in HTTPS. To avoid silly errors, customers need to enforce the protocol.

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@djejaquino djejaquino requested a review from a team as a code owner March 7, 2024 16:57
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers-basistheory-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 4:58pm

@djejaquino
Copy link
Contributor Author

This lives in our side, not the customer's.

@djejaquino djejaquino closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant