Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding considerations for tokenization #354

Merged
merged 5 commits into from
Mar 25, 2024
Merged

adding considerations for tokenization #354

merged 5 commits into from
Mar 25, 2024

Conversation

armsteadj1
Copy link
Contributor

Description

  • Considerations for using tokenize in js projects.

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@armsteadj1 armsteadj1 requested a review from a team as a code owner March 22, 2024 17:19
Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers-basistheory-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 6:59pm

Copy link
Contributor

@djejaquino djejaquino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add the same comment to React / React Native (if we do it in both)?

Basis Theory {{ language }} SDK uses camel case for most methods and converts these properties to snake case when sending requests to the API.

docs/sdks/web/javascript/index.mdx Outdated Show resolved Hide resolved
docs/sdks/server-side/node.mdx Outdated Show resolved Hide resolved
Co-authored-by: Davi Aquino <djejaquino@users.noreply.github.com>
## Before You Begin

This SDK requires the use of an API Key associated with a **Public Application**, which only allows `token:create` or `token:update`
permissions to mitigate the risk that these API keys may be publicly exposed within your frontend applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably don't want to hear this, but this is no longer true - for all these client SDKs. We use Public Apps with no permissions for invoking Proxies and Reactors via Sessions.
I don't expect you to fix in this PR though, we should review the SDKs pages.

@armsteadj1 armsteadj1 merged commit 06c8e6d into master Mar 25, 2024
3 checks passed
@armsteadj1 armsteadj1 deleted the eng-6256 branch March 25, 2024 02:29
@bt-platform-eng
Copy link

🎉 This PR is included in version 1.141.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants