Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enableCopy to JS and react sdk's #78

Merged
merged 4 commits into from
Feb 27, 2023
Merged

feat: add enableCopy to JS and react sdk's #78

merged 4 commits into from
Feb 27, 2023

Conversation

kevinperaza
Copy link
Contributor

Description

  • add enableCopy to JS and react sdk's
  • add validateOnChange to react sdk

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@kevinperaza kevinperaza requested a review from a team as a code owner February 17, 2023 02:01
@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
developers-basistheory-com ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 2:17PM (UTC)

@kevinperaza kevinperaza marked this pull request as draft February 17, 2023 17:01
@kevinperaza kevinperaza marked this pull request as ready for review February 22, 2023 14:23
| `value` | false | _string_ | true | All | Sets a static value for the element input. |
| `enableCopy` | false | _boolean_ | true | [`cardNumber`](/docs/sdks/web/javascript/types#ard-number-element)<br/>[`cardExpirationDate`](/docs/sdks/web/javascript/types#card-expiration-date-element)<br/>[`cardElement`](/docs/sdks/web/javascript/types#card-element) <br/>[`cardVerificationCode`](/docs/sdks/web/javascript/types#card-verification-code-element) | Renders a button to allopw users copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
Copy link
Contributor

@brigonzalez brigonzalez Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `enableCopy` | false | _boolean_ | true | [`cardNumber`](/docs/sdks/web/javascript/types#ard-number-element)<br/>[`cardExpirationDate`](/docs/sdks/web/javascript/types#card-expiration-date-element)<br/>[`cardElement`](/docs/sdks/web/javascript/types#card-element) <br/>[`cardVerificationCode`](/docs/sdks/web/javascript/types#card-verification-code-element) | Renders a button to allopw users copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
| `enableCopy` | false | _boolean_ | true | [`cardNumber`](/docs/sdks/web/javascript/types#ard-number-element)<br/>[`cardExpirationDate`](/docs/sdks/web/javascript/types#card-expiration-date-element)<br/>[`cardElement`](/docs/sdks/web/javascript/types#card-element) <br/>[`cardVerificationCode`](/docs/sdks/web/javascript/types#card-verification-code-element) | Renders a button to allow users to copy the value of the element to the browser's clipboard without your application ever interacting with the data. |

| `onKeyDown` | false | _function_ | true | Event Listener. See [On Keydown](/docs/sdks/web/javascript/methods#on-keydown) |
| `ref` | false | _object/function_ | false | [Ref object](/docs/sdks/web/react#using-refs)/[Callback ref function](https://reactjs.org/docs/refs-and-the-dom.html) to store/receive the Element instance. |
| `validateOnChange` | false | _boolean_ | false | Enable validation `onChange` |
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the element to the browser's clipboard without your application ever interacting with the data. |

| `onKeyDown` | false | _function_ | true | Event listener. See [On Keydown](/docs/sdks/web/javascript/methods#on-keydown) |
| `ref` | false | _object/function_ | false | [Ref object](/docs/sdks/web/react#using-refs)/[Callback ref function](https://reactjs.org/docs/refs-and-the-dom.html) to store/receive the Element instance. |
| `validateOnChange` | false | _boolean_ | false | Enable validation `onChange` |
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the element to the browser's clipboard without your application ever interacting with the data. |

| `onKeyDown` | false | _function_ | true | Event listener. See [On Keydown](/docs/sdks/web/javascript/methods#on-keydown) |
| `ref` | false | _object/function_ | false | [Ref object](/docs/sdks/web/react#using-refs)/[Callback ref function](https://reactjs.org/docs/refs-and-the-dom.html) to store/receive the Element instance. |
| `validateOnChange` | false | _boolean_ | false | Enable validation `onChange` |
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the element to the browser's clipboard without your application ever interacting with the data. |

| `onKeyDown` | false | _function_ | true | Event listener. See [On Keydown](/docs/sdks/web/javascript/methods#on-keydown) |
| `ref` | false | _object/function_ | false | [Ref object](/docs/sdks/web/react#using-refs)/[Callback ref function](https://reactjs.org/docs/refs-and-the-dom.html) to store/receive the Element instance. |
| `validateOnChange` | false | _boolean_ | false | Enable validation `onChange` |
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the elements to the browser's clipboard without your application ever interacting with the data. |
| `enableCopy` | false | _boolean_ | false | Renders a button so your users can copy the value of the element to the browser's clipboard without your application ever interacting with the data. |

@kevinperaza kevinperaza merged commit a33d5a5 into master Feb 27, 2023
@kevinperaza kevinperaza deleted the eng-4085 branch February 27, 2023 17:21
bt-platform-eng pushed a commit that referenced this pull request Feb 27, 2023
# [1.34.0](v1.33.0...v1.34.0) (2023-02-27)

### Features

* add `enableCopy` to JS and react sdk's ([#78](#78)) ([a33d5a5](a33d5a5))
@bt-platform-eng
Copy link

🎉 This PR is included in version 1.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants