Use session in document insert #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andraghetti
force-pushed
the
missing-session-insert
branch
from
4c17e6c
to
280e92c
Compare
adeelsohailahmed
approved these changes
Sep 5, 2024
|
@adeelsohailahmed Hi! Is there a way to expedite the process? Can we ping other collaborators to review? |
Beyond requesting a review from the team (which I've already done), I don't think there's much we can do. |
That’s perfect! Thank you 👍 |
ayusshsoarav
approved these changes
Sep 12, 2024
|
Nice! Thank you! Can somebody merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a transactional integrity issue in Beanie by ensuring that document saves are correctly associated with the current transaction session.
Problem
When saving documents within a transaction using Beanie, a bug causes linked documents to be saved outside the transaction context if the session parameter is not explicitly provided. This behavior can lead to partial updates where some documents are persisted even if the transaction fails, undermining the purpose of using transactions.
Solution
The change explicitly adds
session=sessionto thesavefunction for documents within a transaction. This ensures that all document saves are bound to the active transaction, preventing unintended persistence of documents if the transaction is rolled back.This fix maintains the atomicity of transactions by ensuring all operations are executed within the transaction context, thus preserving data consistency and integrity.