Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #1008 in the json_schema export of document with BackLink #1019

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gdlmx
Copy link

@gdlmx gdlmx commented Sep 5, 2024

This PR fixes bug #1008 and adds test for the model_json_schema() method of a document with a BackLink.

Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Several of the tests are failing. Could you please look into them?

Please update the title and make it a bit more descriptive as well.

@gdlmx gdlmx changed the title Fix: bug #1008 in BackLink.model_json_schema() Fix bug #1008 in the json_schema export of document with BackLink Sep 5, 2024
@gdlmx
Copy link
Author

gdlmx commented Sep 5, 2024

I have changed the title as requested. The failed test is caused by a bug in Pydantic V1. I cannot find an elegant solution, so I have to disable the test_json_schema_export for V1.

@adeelsohailahmed adeelsohailahmed requested a review from a team September 11, 2024 23:25
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants