Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Encoder #584

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Refactor Encoder #584

merged 3 commits into from
Oct 12, 2023

Conversation

gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Jun 3, 2023

I took a stab at simplifying the encoder module a bit.

@gsakkis gsakkis force-pushed the refactor-encoder branch 7 times, most recently from 47bcfe2 to 52d6560 Compare June 4, 2023 17:17
@roman-right
Copy link
Member

Hi! Sorry for the delay.
I'll check this PR by the end of the week

@roman-right roman-right added the bug Something isn't working label Aug 3, 2023
@aksswami
Copy link

Can we merge this PR on priority? I am getting issue with Numpy array with beanie.

@roman-right
Copy link
Member

Hey @gsakkis,
Sorry for the late reply. I had a lot of work to do to make Pydantic v2 work. It seems there are now many conflicts - it's hard to check. Could you please resolve them? Ping me on Discord once you've resolved them so I can get back to you faster.

@gsakkis
Copy link
Contributor Author

gsakkis commented Sep 17, 2023

@roman-right all conflicts have been resolved.

@roman-right roman-right merged commit 587cbdf into BeanieODM:main Oct 12, 2023
20 of 21 checks passed
@roman-right
Copy link
Member

Thank you! It will be published by the end of this week together with others

@gsakkis gsakkis deleted the refactor-encoder branch October 21, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action requested bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants