Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index support for custom pydantic types #699

Closed
wants to merge 0 commits into from

Conversation

aasay
Copy link
Contributor

@aasay aasay commented Sep 12, 2023

This allows custom pydantic types to used with indexes

@roman-right
Copy link
Member

Hi @aasay,
You use walrus operator, which isn't supported by Python 3.7 (welcome to my reality :D). Can you please use less modern syntax? I plan to support 3.7 at least for this year.

@aasay
Copy link
Contributor Author

aasay commented Sep 14, 2023

@roman-right,

Sorry about that. I get very accustomed to using the newer versions of python and didn't even think about it. It is updated now if you want to give it a try again.

@roman-right
Copy link
Member

Hi @aasay
I'm sorry, it looks like I produced a conflict. Please let me know, if you can fix it. Alternatively I'll pick it up. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants