Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BsonBinary #739

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Oct 12, 2023

Just like DecimalAnnotation, BsonBinary can be simplified significantly.

@roman-right
Copy link
Member

Hi @gsakkis
It looks like it doesn't work with Pydantic V1

@gsakkis
Copy link
Contributor Author

gsakkis commented Oct 13, 2023

Fixed the tests to work on v1 too.

@roman-right roman-right merged commit d9eb71d into BeanieODM:main Oct 13, 2023
21 checks passed
@roman-right
Copy link
Member

Merged. Will be published tomorrow. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants