-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Generic secrets and bump pre-commit #988
base: main
Are you sure you want to change the base?
Conversation
bfd0bce
to
63c0a58
Compare
63c0a58
to
628af73
Compare
Might want to fix the merge conflicts haha, nice pull request though! |
6529603
to
f672611
Compare
@LawMixer fixed |
f672611
to
bbe9ea0
Compare
@adeelsohailahmed can i get another opinion thanks |
bbe9ea0
to
1ee8cbe
Compare
bcdff2b
to
89b9213
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes. I just have some minor nitpicks.
6bc67aa
to
17e311c
Compare
@adeelsohailahmed nitpicks adressed will follow them in future as well |
161cdcb
to
9d7eb77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several steps of GA failed, they need correction to approve this PR.
1d27bc1
to
b32d7d7
Compare
@Riverfount typo in test matrix configuration... Fixed |
…python 3.7 add python 3.13 * added badges * added python 3.12 * added mongo 6 and 7 for testing
b32d7d7
to
88a4168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Looks good to me too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.