Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Generic secrets and bump pre-commit #988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

07pepa
Copy link
Member

@07pepa 07pepa commented Aug 1, 2024

No description provided.

@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch 8 times, most recently from bfd0bce to 63c0a58 Compare August 1, 2024 20:21
@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch from 63c0a58 to 628af73 Compare August 14, 2024 19:26
LawMixer
LawMixer previously approved these changes Aug 15, 2024
@LawMixer
Copy link

Might want to fix the merge conflicts haha, nice pull request though!

@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch 3 times, most recently from 6529603 to f672611 Compare August 15, 2024 14:39
@07pepa 07pepa requested a review from LawMixer August 15, 2024 15:10
@07pepa
Copy link
Member Author

07pepa commented Aug 15, 2024

@LawMixer fixed

LawMixer
LawMixer previously approved these changes Aug 15, 2024
@07pepa 07pepa marked this pull request as draft August 15, 2024 20:23
@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch from f672611 to bbe9ea0 Compare August 16, 2024 12:52
@07pepa 07pepa marked this pull request as ready for review August 16, 2024 13:29
@07pepa
Copy link
Member Author

07pepa commented Aug 16, 2024

@adeelsohailahmed can i get another opinion thanks

@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch from bbe9ea0 to 1ee8cbe Compare August 16, 2024 22:09
@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch from bcdff2b to 89b9213 Compare August 17, 2024 10:09
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes. I just have some minor nitpicks.

.github/workflows/github-actions-tests.yml Outdated Show resolved Hide resolved
.github/workflows/github-actions-tests.yml Outdated Show resolved Hide resolved
Riverfount
Riverfount previously approved these changes Aug 22, 2024
@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch 2 times, most recently from 6bc67aa to 17e311c Compare August 27, 2024 07:13
@07pepa
Copy link
Member Author

07pepa commented Aug 27, 2024

@adeelsohailahmed nitpicks adressed will follow them in future as well

@07pepa 07pepa added enhancement New feature or request and removed action requested labels Aug 27, 2024
@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch 3 times, most recently from 161cdcb to 9d7eb77 Compare August 27, 2024 11:05
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several steps of GA failed, they need correction to approve this PR.

@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch 3 times, most recently from 1d27bc1 to b32d7d7 Compare August 27, 2024 19:08
@07pepa
Copy link
Member Author

07pepa commented Aug 27, 2024

@Riverfount typo in test matrix configuration... Fixed

@07pepa 07pepa requested a review from Riverfount August 27, 2024 19:26
@07pepa 07pepa mentioned this pull request Aug 27, 2024
pyproject.toml Outdated Show resolved Hide resolved
tests/odm/test_secrets.py Outdated Show resolved Hide resolved
…python 3.7 add python 3.13

* added badges
* added python 3.12
* added mongo 6 and 7 for testing
@07pepa 07pepa force-pushed the add-arbitrary-secrets-support branch from b32d7d7 to 88a4168 Compare August 29, 2024 07:13
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Looks good to me too.

Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants