Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-emoji] default css is a little wonky #90

Closed
warren-bank opened this issue Jun 29, 2024 · 1 comment · Fixed by #92 or #94
Closed

[plugin-emoji] default css is a little wonky #90

warren-bank opened this issue Jun 29, 2024 · 1 comment · Fixed by #92 or #94
Labels

Comments

@warren-bank
Copy link
Contributor

I adjusted my own instance with:

  import '@cartamd/plugin-emoji/default.css'
  import './css/emoji.css'

where emoji.css includes the following overrides:

.carta-emoji {
  display: block !important;
  word-break: break-word !important;
  overflow-x: auto;
  overflow-y: auto !important;
}

.carta-emoji button {
  display: inline-block !important;
  margin: 3px;
  height: 2rem;
  aspect-ratio: unset !important;
  white-space: nowrap;
}

to summarize:

  • the main issue is that several emoji codes each resolve to a sequence of unicode characters
  • the default css uses a grid layout, so an extra wide button stretches the width of an entire column
  • the default css uses an aspect ratio of 1, so an extra wide button is also made extra tall.. and stretches the height of an entire row

test case:

  1. type: :h
  2. type: :he
  3. type: :hea
    • several of the heart emojis are multi character
warren-bank added a commit to warren-bank/fork-js-svelte-carta that referenced this issue Jun 29, 2024
fix BearToCode#90

change from a grid layout to a block element containing inline buttons
warren-bank added a commit to warren-bank/fork-js-svelte-carta that referenced this issue Jul 2, 2024
fix BearToCode#90

change from a block element w/ inline buttons to a flexbox layout
BearToCode pushed a commit to warren-bank/fork-js-svelte-carta that referenced this issue Jul 2, 2024
fix BearToCode#90

change from a block element w/ inline buttons to a flexbox layout
BearToCode added a commit that referenced this issue Jul 2, 2024
* add 'input' event handler for mobile browsers w/ virtual keyboard

* [plugin-emoji] update 'default.css'

fix #90

change from a block element w/ inline buttons to a flexbox layout

* format and adjustments

---------

Co-authored-by: BearToCode <davidebasso03@gmail.com>
Copy link

github-actions bot commented Jul 2, 2024

🎉 This issue has been resolved in version @cartamd/plugin-emoji-v4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant