Skip to content

Commit

Permalink
Merge pull request opencv#247 from cbalint13/daisy
Browse files Browse the repository at this point in the history
Bugfix Normalization / Enhance "float/double" mode queries for DAISY.
  • Loading branch information
vpisarev committed Jun 3, 2015
2 parents d4f651e + cef5666 commit 6123e89
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions modules/xfeatures2d/src/daisy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -519,8 +519,7 @@ static void normalize_sift_way( float* desc, const int _descriptor_size )
double sum = 0.0f;
for( int i=0; i<_descriptor_size; i++ )
{
sum += desc[_descriptor_size + i]
* desc[_descriptor_size + i];
sum += desc[i] * desc[i];
}

float norm = (float)sqrt( sum );
Expand All @@ -529,7 +528,7 @@ static void normalize_sift_way( float* desc, const int _descriptor_size )
// divide with norm
for( int i=0; i<_descriptor_size; i++ )
{
desc[_descriptor_size + i] /= norm;
desc[i] /= norm;
}

for( h=0; h<_descriptor_size; h++ )
Expand All @@ -549,8 +548,7 @@ static void normalize_full( float* desc, const int _descriptor_size )
double sum = 0.0f;
for( int i=0; i<_descriptor_size; i++ )
{
sum += desc[_descriptor_size + i]
* desc[_descriptor_size + i];
sum += desc[i] * desc[i];
}

float norm = (float)sqrt( sum );
Expand All @@ -559,7 +557,7 @@ static void normalize_full( float* desc, const int _descriptor_size )
// divide with norm
for( int i=0; i<_descriptor_size; i++ )
{
desc[_descriptor_size + i] /= norm;
desc[i] /= norm;
}
}

Expand Down Expand Up @@ -1547,8 +1545,6 @@ void DAISY_Impl::compute( InputArray _image, Rect roi, OutputArray _descriptors
// compute full desc
compute_descriptors( &descriptors );
normalize_descriptors( &descriptors );

release_auxiliary();
}

// full scope
Expand Down Expand Up @@ -1576,8 +1572,6 @@ void DAISY_Impl::compute( InputArray _image, OutputArray _descriptors )
// compute full desc
compute_descriptors( &descriptors );
normalize_descriptors( &descriptors );

release_auxiliary();
}

// constructor
Expand Down

0 comments on commit 6123e89

Please sign in to comment.