Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile creation missing disable-sgn flag in v1.5.32 #1055

Closed
mttaggart opened this issue Jan 4, 2023 · 1 comment
Closed

Profile creation missing disable-sgn flag in v1.5.32 #1055

mttaggart opened this issue Jan 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mttaggart
Copy link

Describe the bug
When running profiles new, the client crashes, missing a registered disable-sgn flag, which seems to have been added, according to the changenotes.

To Reproduce
Steps to reproduce the behavior:

  1. Run profiles new -f exe --mtls 127.0.0.1:8888 test_mtls
  2. Observe the following error
panic: missing flag value: flag 'disable-sgn' not registered

goroutine 1 [running]:
github.com/desertbit/grumble.FlagMap.Bool(0x1769b7a?, {0x1783234, 0xb})
        github.com/desertbit/grumble@v1.1.1/flagmap.go:72 +0x105
github.com/bishopfox/sliver/client/command/generate.parseCompileFlags(0xc0005f2080, 0xc00009a320)
        github.com/bishopfox/sliver/client/command/generate/generate.go:349 +0x110d
github.com/bishopfox/sliver/client/command/generate.ProfilesNewCmd(0xc0005f2080, 0xc00009a320)
        github.com/bishopfox/sliver/client/command/generate/profiles-new.go:31 +0x53
github.com/bishopfox/sliver/client/command.BindCommands.func148(0xc0005f0060?)
        github.com/bishopfox/sliver/client/command/commands.go:1583 +0x45
github.com/desertbit/grumble.(*App).RunCommand(0xc000034540, {0xc000410080?, 0x3a?, 0x1bf6548?})
        github.com/desertbit/grumble@v1.1.1/app.go:273 +0x19f
github.com/desertbit/grumble.(*App).runShell(0xc000034540)
        github.com/desertbit/grumble@v1.1.1/app.go:485 +0x4e6
github.com/desertbit/grumble.(*App).RunWithReadline(0xc000034540, 0xc0003934d0)
        github.com/desertbit/grumble@v1.1.1/app.go:407 +0x570
github.com/desertbit/grumble.(*App).Run(0xc000034540)
        github.com/desertbit/grumble@v1.1.1/app.go:291 +0x125
github.com/bishopfox/sliver/client/console.Start({0x1c65038?, 0xc0000402d0}, 0x1a4e798, 0x1a4e0f8, 0x0)
        github.com/bishopfox/sliver/client/console/console.go:145 +0x577
github.com/bishopfox/sliver/client/cli.StartClientConsole()
        github.com/bishopfox/sliver/client/cli/cli.go:100 +0x1a6
github.com/bishopfox/sliver/client/cli.glob..func1(0x262e6e0?, {0x175b4fa?, 0x0?, 0x0?})
        github.com/bishopfox/sliver/client/cli/cli.go:74 +0x73
github.com/spf13/cobra.(*Command).execute(0x262e6e0, {0xc000118210, 0x0, 0x0})
        github.com/spf13/cobra@v1.6.1/command.go:920 +0x847
github.com/spf13/cobra.(*Command).ExecuteC(0x262e6e0)
        github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/cobra@v1.6.1/command.go:968
github.com/bishopfox/sliver/client/cli.Execute()
        github.com/bishopfox/sliver/client/cli/cli.go:105 +0x25
main.main()
        github.com/bishopfox/sliver/client/main.go:43 +0x17

Expected behavior
The profile should be saved without issue

Screenshots
image

Desktop (please complete the following information):

  • OS: Kali Linux
@FLeiXiuS
Copy link
Contributor

FLeiXiuS commented Jan 4, 2023

This is my doing, I'll fix this in the morning.

@moloch-- moloch-- added the bug Something isn't working label Jan 4, 2023
moloch-- added a commit that referenced this issue Jan 4, 2023
moloch-- added a commit that referenced this issue Jan 4, 2023
@moloch-- moloch-- closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants