Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pairing: remove impossible panic #1249

Merged
merged 1 commit into from
Jul 17, 2024
Merged

pairing: remove impossible panic #1249

merged 1 commit into from
Jul 17, 2024

Conversation

benma
Copy link
Collaborator

@benma benma commented Jul 11, 2024

Good to avoid panics, plus it save some bytes in the binary for code that never executes.

Good to avoid panics, plus it save some bytes in the binary for code
that never executes.
@benma benma requested a review from asi345 July 11, 2024 13:08
@benma benma changed the title rpairing: remove impossible panic pairing: remove impossible panic Jul 11, 2024
Copy link
Collaborator

@asi345 asi345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, nice finding!

@benma benma merged commit 6620ee3 into BitBoxSwiss:master Jul 17, 2024
1 check passed
@benma benma deleted the utf8 branch July 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants