Limit the amounts of events created [wip] #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are some UI glitches due to missed events. This patch will limit the amount of events that are emitted by checking at which systick the same event was emitted last time. Fixes the UI glitch with the long press in the PW entry.
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 40.61% 40.68% +0.07%
==========================================
Files 94 95 +1
Lines 5341 5348 +7
==========================================
+ Hits 2169 2176 +7
Misses 3172 3172
Continue to review full report at Codecov.
|
|
I can't reproduce the issue right now. We will have to wait with reviewing this issue until we can reliably reproduce it. I did manage to see the issue when I wrote the fix. |
NickeZ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.