Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history: show value in XEC units #220

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

PiRK
Copy link
Collaborator

@PiRK PiRK commented Jun 17, 2022

There was still a hardcoded decimal_point=8 in the code. This caused the history command line to show values/fees/amounts in MegaXEC instead of XEC.

Before:

$./ElectrumABC-5.1.2-9-gdedc670cb-x86_64.AppImage history
[
    {
        "balance": "0.175",
        "confirmations": 6,
        "date": "2022-02-02 02:02",
        "fee": "0.00000807",
        "height": 777777,
        "label": "",
        "timestamp": 1655555555,
        "txid": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
        "value": "+0.075"
    },
    {
        "balance": "0.1",
        "confirmations": 6,
        "date": "2022-02-02 02:02",
        "fee": "0.00000452",
        "height": 777777,
        "label": "",
        "timestamp": 1655555555,
        "txid": "yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy",
        "value": "+0.1"
    }
]

There was still a hardcoded `decimal_point=8` in the code. This caused the `history` command line to show values in MegaXEC instead of XEC.
@PiRK PiRK merged commit 5ba8478 into Bitcoin-ABC:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant