Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve auxiliary keys window and key generation for a delegation #240

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

PiRK
Copy link
Collaborator

@PiRK PiRK commented Sep 15, 2022

Change the auxiliary keys window to:

  • show the keys in a QLineEdit widget which allows copying the text on all systems (previously windows and Mac users reported not being able to copy the generated key)
  • show one key at a time, select the key index in a QSpinBox (allowed range: 0 - 1000)
  • reuse that dialog when generating a delegated key in the delegation editor, to allow choosing from more than one key

The first commit is a refactoring, splitting the ever growing avalanche_dialogs.py module into submodules in a new qt.avalanche subpackage.

Split the avalanche_dialogs classes in submodules of a `qt.avalanche` package.
Change the auxiliary key window to:
- show the keys in a QLineEdit widget which allow copying the text on all systems
- show one key at a time, select the key index in a QSpinBox (allowed range: 0 - 1000)
- reuse that dialog when generating a delegated key in the delegation editor, to allow choosing from more than one key
@PiRK PiRK merged commit 6955534 into Bitcoin-ABC:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant