More linting #262
Merged
More linting #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the unused ones, move the ones that a single-used directly to the callsite, use a proper def for others
BaseException is the base class for all builtin exceptions, including stuff like SystemExit and KeyboardInterrupt. It is rarely a good idea to catch those. This is equivalent to bare except clauses (see next commit) The official python documentation explicitely says to not directly inherit this for custom exceptions, but inherit Exception instead. When it comes to explicitely raising an error, RuntimeError is generic enough and can be caught with a generic `except Exception`.
I did this semi-automatically by just replacing bare exceptions with `except Exception`. It is still awful, but at least we no longer catch `KeyboardInterrupt` and `SystemExit`. Fixing this properly would take an enormous amount of work, understanding each one of the 100+ occurences to guess the correct exceptions to catch. This will have to be done the slow way, each occurence at a time when the code is touched for another reason.
This improves the code formatting by black
This is explicitely prohibited by PEP 484
Focus on the longest comments that are most likely to cause problems with black formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix as many flake8 errors as possible, so that the tool can be run without ignoring anything.
Addresses #252