Fix the plugin selection dialog #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has never been enabled in Electrum ABC because the server is notoriously unreliable for large wallets. It has been dropped in Electron Cash too. No one has been able to come up with a workable alternative solution.
This is a regression in commit 989e161
After commit 989e161, `descr["__name__"]` no longer matches the short name key expected by `plugins.get_internal_plugin(name)`. As a result, all plugins in that menu dialog were greyed out, and the user could no longer disable or enable a plugin. For existing users, everything stayed the same (previously enabled plugins stayed enabled and vice-versa), so the damage is mainly limited to new users not being able to enable CashFusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal plugin selection dialog (menu "Optional Features") no longer works due to a regression in commit 89e1613b820bc8cf7d42766b148edeadde35a14
This fixes it.