Fix testnet ASERTDaa anchor #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had the wrong value. Source: https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/blob/master/src/chainparams.cpp#L348 It didn't matter that it had the wrong value since it was behind a checkpoint. But still, it is worth fixing.
Previously I didn't backport the testnet changes for Electron-Cash@3f63318 > The issues manifests itself whenever the checkpoint block is after > the asert anchor. This caused the code in blockchain.py to have a bad time. > > The asert anchor calculation code needs all headers, but if we have a > checkpoint after the anchor, all headers are not always available. The fix > is to either have checkpoints before the anchor, or to hard-code the anchor. > > This is the case for all chains we support now. It broke headers synchronization when I set a new tesnet checkpoint on November 15th 2021, but I didn't notice because I already had a complete header chain so it did not trigger the bug for me. But for a user who does not already have the headers prior to the checkpoint locally, it causes the headers synchronization to fail.
The difficulty adjustment for eCash testnet has the same half-life as for eCash MainNet. This paramameter is only used on the BCH chain. This is a follow-up to commit bf82557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression preventing header synchronization for testnet3 after the previous checkpoint bump. The checkpoint was bumped after the ASERT anchor, which made the automatic computation of the Anchor not work for new users because of missing headers.
Fix header synchronization by explicitly specifying the anchor parameters.
This was not detected before because the bug did not manifest itself if all the headers were already present locally.