Mac OS build related electrum backports #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some places in the script if some directory name had spaces it could cause issues. I also added quotes around a few other directory names that currently are hardcoded with names without spaces as a way to prevent any future mishap backport of spesmilo@bc72e0f#diff-a506f45e9d57ded6cf91a31f441f3f2783a6b0383194912b63b85ebfb02921ffR114
The .pyc files would get created when a .py module is imported, which is done during the build for some source files by pyinstaller (when it analyses imports). backport of spesmilo@659c00e
We are trying to make the macOS builds reproducible... Compiling python from source on OSX seems to be very difficult in a reproducible way. As a workaround, we make the same tradeoff the Windows binaries already have: we trust the python binaries distributed by python.org. backport of spesmilo@4fd6282
It looks like the python installed from python.org does not install `pyinstaller` on the path.
note: newer versions of pyinstaller (4.4+ ?) want to sign the bundle themselves, in which case modifying the Info.plist file after pyinstaller returns invalidates the sig.
custom args no longer work with pyinstaller 5.0 (see pyinstaller/pyinstaller#6762 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grab interesting Electrum commits to be able to bump the pyinstaller version, and hopefully make multiprocessing work for the generated MacOS package.
See #279 (comment)