fix integer overflow for amount selection #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt translates `int` into a C int (32 bytes signed integer), which causes overflows when the selected amount in satoshis is larger than the int32 max. The tradeoff of using a generic PythonObject is performance, as there will be a lot of overhead. But this is not an issue as this codepath is only triggered rarely and at low frequency, by users cliocking on coins or addresses in the GUI.
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 14, 2023
Summary: PyQt translates python integers to signed 32 bits int when emitting a `int` in a signal. We need to specifically emit a 64 bit integer. See https://doc.qt.io/qt-5/qtglobal.html#quint64-typedef Also apply the same fix to the two signals that I previously fixed in a different way (with a larger performance overhead) in Bitcoin-ABC/ElectrumABC#291 Test Plan: load a proof with a total stake of more than 21,474,836.47 XEC, check the amount is displayed correctly. Select coins and addresses of various amounts, check the selected amount displayed in the status bar. Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D14781
Fabcien
pushed a commit
that referenced
this pull request
Nov 14, 2023
Summary: PyQt translates python integers to signed 32 bits int when emitting a `int` in a signal. We need to specifically emit a 64 bit integer. See https://doc.qt.io/qt-5/qtglobal.html#quint64-typedef Also apply the same fix to the two signals that I previously fixed in a different way (with a larger performance overhead) in #291 Test Plan: load a proof with a total stake of more than 21,474,836.47 XEC, check the amount is displayed correctly. Select coins and addresses of various amounts, check the selected amount displayed in the status bar. Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D14781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt translates
intinto a C int (32 bytes signed integer), which causes overflows when the selected amount in satoshis is larger than the int32 max.The tradeoff of using a generic PythonObject is performance, as there will be a lot of overhead. But this is not an issue as this codepath is only triggered rarely and at low frequency, by users cliocking on coins or addresses in the GUI.