Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A rough draft of some microbenchmarking tools. #57

Merged
merged 36 commits into from
Nov 10, 2019

Conversation

Sqeaky
Copy link
Member

@Sqeaky Sqeaky commented Sep 22, 2019

I need to review the docs and determine which other percentiles are desired. I am submitting this to CI to prepare for PR.

I need to review the docs and determine which other percentiles are desired. I am submitting this to CI to prepare for
PR.
@Sqeaky Sqeaky added this to the PreJagatiSprint milestone Sep 22, 2019
@Sqeaky
Copy link
Member Author

Sqeaky commented Sep 22, 2019

This isn't ready yet, I just want to see what CI does.

predictability/reliability where the compiler is not optimizing.
Copy link
Member

@MakoEnergy MakoEnergy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review pass. In addition to comments I left, I have mixed feelings about documenting classes created exclusively for test use (for reference, you didn't in this PR).

include/TestEnumerations.h Outdated Show resolved Hide resolved
include/TestMacros.h Outdated Show resolved Hide resolved
include/TimingTools.h Outdated Show resolved Hide resolved
include/TimingTools.h Outdated Show resolved Hide resolved
include/TimingTools.h Outdated Show resolved Hide resolved
include/TimingTools.h Outdated Show resolved Hide resolved
test/TimedTestTests.h Outdated Show resolved Hide resolved
test/TimedTestTests.h Outdated Show resolved Hide resolved
test/TimedTestTests.h Outdated Show resolved Hide resolved
test/TimedTestTests.h Outdated Show resolved Hide resolved
@MakoEnergy MakoEnergy merged commit 0bf3c6f into master Nov 10, 2019
@MakoEnergy MakoEnergy deleted the Feature-Microbenchmarks branch November 10, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants