Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even better qdrant killing #878

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Even better qdrant killing #878

merged 1 commit into from
Aug 23, 2023

Conversation

rsdy
Copy link
Contributor

@rsdy rsdy commented Aug 21, 2023

Make the second attempt fail gracefully. There's not much point panicing here, as the app is supposed to be shutting down anyway.

It seems like ExitRequested is skipped on a Mac when using eg. CMD-Q to quit.

@rsdy rsdy added the bug Something isn't working label Aug 21, 2023
@rsdy rsdy requested a review from ggordonhall August 21, 2023 18:02
@ggordonhall ggordonhall self-requested a review August 22, 2023 20:55
@rsdy rsdy merged commit f1b291f into main Aug 23, 2023
2 checks passed
@rsdy rsdy deleted the qdrant-doesnt-stop2 branch August 23, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants