-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix closing div & endif placement #594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessecowens
approved these changes
Jan 11, 2022
jamesros161
added a commit
that referenced
this pull request
Jan 27, 2022
* apply correct typography classes (#591) * apply correct typography classes * fix arrow alignments * add Hamburger device display controls (#590) * add Hamburger device display controls * fix header alignments * add custom button controls to customizer (#583) * add custom button controls to customizer * add front-end functionality to custom buttons * add typography controls * refactor button controls * fix alignments * Prevent extra closing div tag (#589) The opening div tag is only written if the post type is hierarchical, but the closing div tag is output regardless of that check. Move close div tag inside the if statement to prevent layout issues for non-hierarchical post types using layouts * resolves 382 (#582) * resolves 382 * commenting / styling fixes * resolves 553 (#581) * phpcs fixes * fix 'yoda' conditional error cuase phpcs is dumb * update versions for beta1 * fix responsive button font location * update buttons library in yarn.lock * add button fonts to ppb editor presets (#597) * fix incorrect enqueue notice (#598) * fix hr indentation (#599) * Fix inconsistent Link hovers (#600) * fix closing div & endif placement * Fix inconsistent link hover effects * fix closing div & endif placement (#594) * fix footer typography settings * add ham classes to menus * re-order hamburger display controls * fix top of border button menu items * fix margin on footer menu tablet * update rc version numbers * do not apply custom button styles to submit * default button font matches body font * remove transparent border color * add alignment to hamburger menus * update yarn.lock and site-title selector * fix site title selectors * fix missing edit button on footer menus * update version numbers * add function comment * update buttons * default button line height 40px * set secondary defaults * add btn class to all buttons * fix buttons * update buttons dep * fix side headers * update readme and versions * update package.json * fix breakpoint * correct comments in preview.js * add comments to link-preview.js * add doc blocks to front-end.js * fix alignmentq * remove extra lines * fix formatting Co-authored-by: Jesse Owens <jesse@jessecowens.com>
jamesros161
added a commit
that referenced
this pull request
Jan 31, 2022
* apply correct typography classes (#591) * apply correct typography classes * fix arrow alignments * add Hamburger device display controls (#590) * add Hamburger device display controls * fix header alignments * add custom button controls to customizer (#583) * add custom button controls to customizer * add front-end functionality to custom buttons * add typography controls * refactor button controls * fix alignments * Prevent extra closing div tag (#589) The opening div tag is only written if the post type is hierarchical, but the closing div tag is output regardless of that check. Move close div tag inside the if statement to prevent layout issues for non-hierarchical post types using layouts * resolves 382 (#582) * resolves 382 * commenting / styling fixes * resolves 553 (#581) * phpcs fixes * fix 'yoda' conditional error cuase phpcs is dumb * update versions for beta1 * fix responsive button font location * update buttons library in yarn.lock * add button fonts to ppb editor presets (#597) * fix incorrect enqueue notice (#598) * fix hr indentation (#599) * Fix inconsistent Link hovers (#600) * fix closing div & endif placement * Fix inconsistent link hover effects * fix closing div & endif placement (#594) * fix footer typography settings * add ham classes to menus * re-order hamburger display controls * fix top of border button menu items * fix margin on footer menu tablet * update rc version numbers * do not apply custom button styles to submit * default button font matches body font * remove transparent border color * add alignment to hamburger menus * update yarn.lock and site-title selector * fix site title selectors * fix missing edit button on footer menus * update version numbers * add function comment * update buttons * default button line height 40px * set secondary defaults * add btn class to all buttons * fix buttons * update buttons dep * fix side headers * update readme and versions * update package.json * fix breakpoint * correct comments in preview.js * add comments to link-preview.js * add doc blocks to front-end.js * fix alignmentq * remove extra lines * fix formatting * button fixes * more bug fixzes * button fixes * update buttons yarn.lock Co-authored-by: Jesse Owens <jesse@jessecowens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #593