NIM-3358 - Add AA rels and classes #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanDevos
commented
Oct 7, 2024
index.js
Outdated
| @@ -1,4 +1,6 @@ | |||
| export const Rels = { | |||
| // rels with no domain (IANA) | |||
| self: 'self', | |||
There was a problem hiding this comment.
I'm not sure about this... would it be better just to use the 'self' string rather than adding this to hypermedia constants? I could go either way
There was a problem hiding this comment.
Just thought about it, and the idea of having this is a constant is so that if we need to change it, we only need to change it in one place.
But since this is a standard rel identifier, it can't ever really "change" so doesn't really need to be here.
I'm gonna remove it from here
amauryperez
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://desire2learn.atlassian.net/browse/NIM-3358
Required by: https://github.com/BrightspaceHypermediaComponents/activities/pull/4937