Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote computers #7

Merged
merged 9 commits into from
May 22, 2024
Merged

Remote computers #7

merged 9 commits into from
May 22, 2024

Conversation

BrytonSalisbury
Copy link
Owner

No description provided.

@BrytonSalisbury BrytonSalisbury linked an issue May 22, 2024 that may be closed by this pull request
@BrytonSalisbury BrytonSalisbury merged commit 0be6471 into master May 22, 2024
1 check passed
@BrytonSalisbury BrytonSalisbury deleted the remote-computers branch May 22, 2024 05:37
const ApiRouter = express.Router();
const bodyParser = require("body-parser");
ApiRouter.use(bodyParser.json({ limit: "10mb" }));
ApiRouter.use(computerListCheck);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a file system access
, but is not rate-limited.
This route handler performs
a file system access
, but is not rate-limited.
Comment on lines +14 to +17
ApiRouter.get("/computerlist", (_req, res) => {
const computerList = JSON.parse(readFileSync(computerPath));
res.json(computerList);
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a file system access
, but is not rate-limited.
Comment on lines +19 to +22
ApiRouter.post("/computerlist", (req, res) => {
writeFileSync(computerPath, JSON.stringify(req.body));
res.json(req.body);
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a file system access
, but is not rate-limited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Store config on server rather than client PCs
1 participant