-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ripgrep-bin installation with linuxbrew #654
Support ripgrep-bin installation with linuxbrew #654
Conversation
Could you tell me how to test this? I don't know what linuxbrew is. |
pkg/brew/ripgrep-bin.rb
Outdated
sha256 "ac595c2239b9a30e0e0744578afa6b73e32cdd8ae61d4f1c0ee5d6b55adbadcf" | ||
when /i686-linux/ | ||
url "https://github.com/BurntSushi/ripgrep/releases/download/#{version}/ripgrep-#{version}-i686-unknown-linux-musl.tar.gz" | ||
sha256 "6e64e7481fbe6019a873a078af13a4aa86ec57a6f94765fd8b57b40d8138560e" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the i686
option? I don't want to devote resources to something people probably won't use. I realize CI produces builds for it, but only because it doesn't cause any trouble. However, if I support this on linuxbrew and decide one day to remove support for it, people might get upset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
54aecfd
to
b6ac5da
Compare
Linuxbrew is a port of homebrew for Linux.
Then install the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, OK, that will be tricky for me to test since I don't want to put a package manager on my system.
I'll accept this for now, and I'll do the "obvious" update whenever I put out a new release of ripgrep and hopefully that will be good enough.
(I do incidentally test this tap on a Mac, but that's because my Mac is strictly for testing this sort of thing. I otherwise don't use it.) |
b6ac5da
to
eb5efb2
Compare
No description provided.