-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] add parser #1619
base: master
Are you sure you want to change the base?
[rust] add parser #1619
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
# cmake_ocr_hardsubx: | ||
# runs-on: macos-latest | ||
# env: | ||
# PKG_CONFIG_PATH: /opt/homebrew/opt/ffmpeg@6/lib/pkgconfig:$PKG_CONFIG_PATH | ||
# FFMPEG_PKG_CONFIG_PATH: /opt/homebrew/opt/ffmpeg@6/lib/pkgconfig | ||
# FFMPEG_INCLUDE_DIR: /opt/homebrew/opt/ffmpeg@6/include | ||
# FFMPEG_LIBS_DIR: /opt/homebrew/opt/ffmpeg@6/lib | ||
# steps: | ||
# - uses: actions/checkout@v4 | ||
# - name: Install dependencies | ||
# run: brew install coreutils pkg-config autoconf automake libtool tesseract leptonica gpac ffmpeg@6 | ||
# - name: cmake | ||
# run: | | ||
# mkdir build && cd build | ||
# cmake -DWITH_OCR=ON -DWITH_HARDSUBX=ON ../src | ||
# - name: build | ||
# run: | | ||
# make -j$(nproc) | ||
# working-directory: build | ||
# - name: Display version information | ||
# run: ./build/ccextractor --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be uncommented?
with: | ||
toolchain: stable | ||
override: true | ||
- name: rustfmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be named test
@@ -6,5 +6,5 @@ cd ..\..\windows | |||
IF "%~1"=="-r" ( | |||
copy x86_64-pc-windows-msvc\release\ccx_rust.lib .\ccx_rust.lib | |||
) ELSE ( | |||
copy x86_64-pc-windows-msvc\debug\ccx_rust.lib .\ccx_rust.lib | |||
copy x86_64-pc-windows-msvc\release-with-debug\ccx_rust.lib .\ccx_rust.lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have release with debug here?
[profile.release-with-debug] | ||
inherits = "release" | ||
debug = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@prateekmedia also fix the merge conflicts |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Rewrote argument parsing with all the structs and enums too into rust.
Help arguments demo:
![image](https://private-user-images.githubusercontent.com/41370460/256812477-1d7cc7f4-7446-492a-a152-a337823abf9e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3MTA4NDUsIm5iZiI6MTcyMjcxMDU0NSwicGF0aCI6Ii80MTM3MDQ2MC8yNTY4MTI0NzctMWQ3Y2M3ZjQtNzQ0Ni00OTJhLWExNTItYTMzNzgyM2FiZjllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAzVDE4NDIyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5MTc4ODc5NWE1N2Y0MTRhZWQ2MzJmYWRjZWM5MTVkYjRhOTI0ZGEyODhjMDExNmRkZTJhMTVlY2M5MTVlMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.maXuZwN9mQ2WD--KuMwa0uYhfj5wyQwHJynEBOaDECU)
Closed old PR as sample platform broke for it: #1547