Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support for setting project/namespace labels #98

Merged
merged 2 commits into from
Sep 22, 2023
Merged

feature: support for setting project/namespace labels #98

merged 2 commits into from
Sep 22, 2023

Conversation

jtriley
Copy link
Collaborator

@jtriley jtriley commented Sep 22, 2023

This allows for setting namespace/project lables in addition to annotations. This is useful, for example, for adding required labels in order to use RHODS with a given project/namespace.

@jtriley
moc_openshift: add labels kwarg to create_project
ac835d7 
This allows for setting namespace/project lables in addition to
annotations.
This was referenced Sep 22, 2023
Closed
Merged
@jtriley jtriley force-pushed the feature-project-labels branch 2 times, most recently from ddf4729 to 024606a Compare September 22, 2023 10:43
@jtriley
Copy link
Collaborator Author

jtriley commented Sep 22, 2023

The linter is complaining about the number of args after adding the labels kwarg. I can configure pylint to ignore/allow more than 5 args otherwise let me know what would be preferred.

@joachimweyl
Copy link

@jtriley it looks like the issue is stuck on the Pre-commit check.

@jtriley
Copy link
Collaborator Author

jtriley commented Sep 22, 2023 •
edited
Loading

@jtriley it looks like the issue is stuck on the Pre-commit check.

Yes see my comment above. About to take off on a flight but will push a fix soon.

@jtriley
create_app: support for setting project/ns labels
97f2326 
This is useful, for example, for enabling RHODS support for a given
namespace/project, e.g.:

opendatahub.io/dashboard: "true"
@jtriley
Copy link
Collaborator Author

jtriley commented Sep 22, 2023

For now I opted to disable that check just for the create_project function by surrounding it with # pylint: disable-msg=too-many-arguments and # pylint: enable-msg=too-many-arguments pragmas. I've also included some minor formatting tweaks that pre-commit was complaining about and auto-correcting.

Please let me know if you'd prefer a different solution cc @knikolla @larsks @naved001

@larsks larsks merged commit 682afb5 into CCI-MOC:master Sep 22, 2023
4 checks passed
@jtriley jtriley deleted the feature-project-labels branch September 22, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsks larsks larsks approved these changes

@naved001 naved001 naved001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtriley @joachimweyl @larsks @naved001