Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find PI's institute by through the order of most qualified domain name #59

Closed
QuanMPhm opened this issue Jun 3, 2024 · 0 comments · Fixed by #62
Closed

Find PI's institute by through the order of most qualified domain name #59

QuanMPhm opened this issue Jun 3, 2024 · 0 comments · Fixed by #62
Assignees

Comments

@QuanMPhm
Copy link
Contributor

QuanMPhm commented Jun 3, 2024

The emails of certain PIs contains multiple subdomains (i.e pi@a.b.edu). Currently, we check for a PI's institute by only matching their full email domain (a.b.edu) to the list of known domains in institute_map.json. For an institution with many subdomains, some of which may match to other institutes, but also many that matches to itself, we would need to add many fully qualified domain names (that share the same second-level, or third-level domain, etc) that would only match to that institution.

Instead of only performing one match against the full domain name, we would like to match through each domain level, from the most qualified to the least.

For example, given the pi email pi@a.b.edu, we should first match against a.b.edu, then b.edu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant