Allow a PI's institution name to be search with subdomains #62
Conversation
| ) | ||
| answers = { | ||
| "q@bu.edu": "Boston University", | ||
| "c@mclean.harvard.edu": "McLean Hospital", |
There was a problem hiding this comment.
would it be helpful to add these items to the test as well?
"childrens.harvard.edu" : "Boston Children's Hospital",
"meei.harvard.edu" : "Massachusetts Eye & Ear",
"dfci.harvard.edu" : "Dana-Farber Cancer Institute",
"bwh.harvard.edu" : "Brigham and Women's Hospital",
"bidmc.harvard.edu" : "Beth Israel Deaconess Medical Center",
There was a problem hiding this comment.
If we want to test more domains, I guess the question would be do we want to test for all the domains in institute_map.json, or just a few examples that validates the get_institution_from_pi function. @naved001 What is your opinion?
There was a problem hiding this comment.
@QuanMPhm I think it's okay to test the additional domains that @joachimweyl suggested.
Now, for PIs whose emails contain multiple subdomains (i.e `a@b.c.edu`), each of their subdomains will be matched against institute_map.json, from the most qualified to least qualified subdomain. In the example of `a@b.c.edu`, this means `b.c.edu` would be matched first, then `c.edu`, then `edu`
QuanMPhm
force-pushed
the
59/institute_domains
branch
from
5e86c9e
to
0b1ee62
Compare
Closes #59. Now, for PIs whose emails contain multiple subdomains (i.e
a@b.c.edu), each of their subdomains will be matched against institute_map.json, from the most qualified to least qualified subdomain.In the example of
a@b.c.edu, this meansb.c.eduwould be matched first, thenc.edu, thenedu.I have removed the "Harvard University" entries from
institute_map.jsonmade redundant by this new feature.