Amending commit to add ability to group invoices by PIs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanMPhm
commented
Apr 1, 2024
| @@ -119,12 +119,12 @@ def export_pi_billables(dataframe: pandas.DataFrame, output_folder): | |||
| if not os.path.exists(output_folder): | |||
| os.mkdir(output_folder) | |||
|
|
|||
| invoice_month = dataframe['Invoice Month'][0] | |||
| invoice_month = dataframe['Invoice Month'].iat[0] | |||
There was a problem hiding this comment.
@naved001 The intent of this line and line 127 was to quickly obtain the invoice month and the PI's instituition name from the dataframe. I tried to get this information by indexing into the first element of the Invoice Month and Institution column.
Using [] for indexing was a form of label indexing equivalent to .loc[], which would raise an error if row 0 of the invoice dataframe was not present (which would happen if the project in the first row was unbillable/excluded). iat[] uses position indexing, which would be the appropriate method for this case.
naved001
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the bug comes from two lines which tries to index into the dataframe. I used an inappropriate method for indexing and this should fix it.