Elasticsearch upgrade #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added basic auth to log in to ES, it is designed to store the username and password in |
techgique
approved these changes
Mar 23, 2023
| @@ -226,7 +229,8 @@ def self.clear_index(options) | |||
|
|
|||
| if confirmation | |||
| data = self.build_clear_data(options) | |||
| RestClient.post(url, data.to_json, { content_type: :json }) { |res, req, result| | |||
| auth_header = Datura::Helpers.construct_auth_header(options) | |||
There was a problem hiding this comment.
Note for future reference on committing. This helper method isn't included in this commit also, so the code would be broken at this commit. It's added in the next commit, but in the future these kinds of things need to be committed together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #175 and also related to CDRH/api#123. Will result in breaking changes if we add it to the release, it will not be possible to post to Elasticsearch 6 under the present code. We could put a setting in the config file and add some conditional logic, but that could require changes to existing repos