Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots/recordings should be affected by screen brightness #326

Closed
2 tasks done
runer112 opened this issue Jul 25, 2019 · 3 comments
Closed
2 tasks done

Screenshots/recordings should be affected by screen brightness #326

runer112 opened this issue Jul 25, 2019 · 3 comments

Comments

@runer112
Copy link
Member

runer112 commented Jul 25, 2019

  • Screenshots
  • APNG recordings
@adriweb
Copy link
Member

adriweb commented Jul 25, 2019

Current implementation draws a black layer with alpha on top of the raw image, and only the raw image is used for screenshots and captures.

Potential solution: use the context painted images/bytes instead of the initial raw image?

@adriweb adriweb added the GUI label Jul 25, 2019
@adriweb
Copy link
Member

adriweb commented Jul 25, 2019

For screenshots, it's trivial, LCDWidget::getImage() should be:

    QPixmap pixmap(size());
    render(&pixmap);
    return pixmap.toImage();

instead of

    m_mutex.lock();
    QImage ret(m_image);
    m_mutex.unlock();
    return ret;

I'll commit that since it doesn't hurt (and also removes the mutex lock), but the problem is much harder if we want to fix that for APNG recordings, since apng_add_frame is called within LCDWidget::draw, and I don't think we want to (which may not be up to date at this point anyway, there is an event that's fired in it to update the widget later on)

@adriweb
Copy link
Member

adriweb commented Jun 26, 2024

This is now working.

@adriweb adriweb closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants