Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 70 #80

Merged
merged 7 commits into from
Feb 16, 2018
Merged

Issue 70 #80

merged 7 commits into from
Feb 16, 2018

Conversation

SkyToGround
Copy link
Contributor

Implements the feature suggested in issue #70. I will be happy to make changes to the feature if you feel any are required in order to merge the code with master.

@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #80   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1365   1294   -71     
=====================================
- Hits         1365   1294   -71
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901b3c2...f4e3400. Read the comment docs.

@henryiii
Copy link
Collaborator

PS: It's okay if formatting doesn't pass, I can auto-fix formatting trivially.

@henryiii
Copy link
Collaborator

Is this inheritable? It is labeled as such, but didn't see it the inheriting part of the code in the diff. I might have missed it, though. I can add it if you need me too.

@SkyToGround
Copy link
Contributor Author

Sorry, that was my mistake. Please tell me (or fix) if I have made other mistakes.

@henryiii henryiii merged commit d465414 into CLIUtils:master Feb 16, 2018
@henryiii
Copy link
Collaborator

LGTM, thanks!

@henryiii henryiii added this to the v1.4 milestone Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants