Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Dependencies of useEffect Hooks #69

Closed
shubhanshu02 opened this issue May 16, 2021 · 5 comments
Closed

Missing Dependencies of useEffect Hooks #69

shubhanshu02 opened this issue May 16, 2021 · 5 comments
Assignees
@Devansh-gaur-1611
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@shubhanshu02
Copy link
Member

Description

In some files, the useEffect has missing dependencies. The issue proposes including such unmet dependencies in the dependencies array of the useEffect hook.

Occurrences

File: pages/hackathon/[slug]/teams/[team_id]/submit.js
Line: 57
Missing Dependency: token

File: pages/hackathon/[slug]/index.js
Line: 77
Missing Dependency: hackathon
@shubhanshu02 shubhanshu02 added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels May 16, 2021
sdiazbarraza pushed a commit to sdiazbarraza/hackalog-frontend that referenced this issue May 16, 2021
Fix missing dependences (COPS-IITBHU#69)
c04b2a3
@sdiazbarraza sdiazbarraza mentioned this issue May 16, 2021
Closed
@shubhanshu02 shubhanshu02 linked a pull request May 18, 2021 that will close this issue
Dependencies #80
Closed
@shubhanshu02 shubhanshu02 mentioned this issue Sep 8, 2021
Merged
5 tasks
@Devansh-gaur-1611
Copy link

Hi @shubhanshu02 bhaiya, is this issue open for now .

@shubhanshu02
Copy link
Member Author

Yes, @Devansh-gaur-1611. You are welcome to put up a PR for that.

@Devansh-gaur-1611
Copy link

Thanks, @shubhanshu02 bhaiya for assigning me. I have started working on this issue and will report you about progress in some time.

@Devansh-gaur-1611
Copy link

Hello @shubhanshu02 bhaiya, I have checked the code and find out that all the dependencies which are specified above have already been added. So bhaiya this issue can be closed.

@shubhanshu02
Copy link
Member Author

Oh, yes right. These changes are covered in #131. Thanks for the catch @Devansh-gaur-1611.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Devansh-gaur-1611 Devansh-gaur-1611

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dependencies ujju20/hackalog-frontend
2 participants
@shubhanshu02 @Devansh-gaur-1611