feat: Merge hugr's schema Value with Const
#172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2024
github-merge-queue bot
pushed a commit
to CQCL/hugr
that referenced
this pull request
Mar 19, 2024
This PR ports the pydantic definition from guppy (including CQCL/guppylang#172), and updates it to sync up with the current schema. Changes to the schema: - Renamed the `InputExtensions` class to `ExtensionSet` - Added a named definition for `Const` - Dropped `DummyOp`. It was referenced in a couple field types, but the model was never defined. The main difference with the model in `guppy` is the use of `RootModel`-based classes instead of variables assigned to a `TypeAliasType` for defining aliases on type unions. They both work the same, but `mypy` doesn't like using variables in types. Additionally, I updated some READMEs and added a CI check to ensure that the json in `specification/schema/` is always up to date.
|
This is now implemented on the hugr repo, CQCL/hugr#888. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the changes from CQCL/hugr#881.
The schema added to hugr's PR was generated from this PR.
This should only be merged once the
quantinuum-hugrdependency is updated to0.3.0, as it will update the validation tests.