Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hugr-py): Make _DfBase and _DefinitionBuilder public #1441

Closed
aborgna-q opened this issue Aug 16, 2024 · 0 comments · Fixed by #1461
Closed

feat(hugr-py): Make _DfBase and _DefinitionBuilder public #1441

aborgna-q opened this issue Aug 16, 2024 · 0 comments · Fixed by #1461
Assignees
@aborgna-q

Comments

@aborgna-q
Copy link
Collaborator

aborgna-q commented Aug 16, 2024 •
edited
Loading

We reference the classes from guppy (in variables that may be any kind of dataflow builder).

We should make the class public (i.e. rename it to DfBase). It's type variable should also be declared as covariant.
@aborgna-q aborgna-q mentioned this issue Aug 16, 2024
Merged
@aborgna-q aborgna-q changed the title feat(hugr-py): Make _DfBase public feat(hugr-py): Make _DfBase and _DefinitionBuilder public Aug 19, 2024
@aborgna-q aborgna-q self-assigned this Aug 21, 2024
@aborgna-q aborgna-q mentioned this issue Aug 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2024
@aborgna-q
refactor!: Make _DfBase and _DefinitionBuilder public (#1461)
ea9cca0 
Closes #1441.

drive-by: Make `Hugr` covariant.

The plan was to make `ParentBuilder` / `DfBase` covariant too, but they
_must_ be invariant since they contain a mutable `Hugr[OpType]`
attribute.

BREAKING CHANGE: Renamed `_DfBase` to `DfBase` and `_DefinitionBuilder`
to `DefinitionBuilder`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: Make _DfBase and _DefinitionBuilder public CQCL/hugr
1 participant
@aborgna-q