feat(hugr-py): IndexDfg builder for appending operations by index
#1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
+ Coverage 86.98% 87.01% +0.02%
==========================================
Files 102 103 +1
Lines 19108 19163 +55
Branches 17015 17015
==========================================
+ Hits 16622 16675 +53
- Misses 1709 1711 +2
Partials 777 777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
approved these changes
Jul 4, 2024
hugr-py/src/hugr/index_dfg.py
Outdated
| as the incoming index. | ||
|
|
||
| Args: | ||
| com: Command to append. |
There was a problem hiding this comment.
Suggested change
| com: Command to append. | |
| com: Command to append. | |
| Raises: | |
| IndexError: If any input index is not a tracked wire. |
hugr-py/src/hugr/index_dfg.py
Outdated
Comment on lines
172
to
173
| Args: | ||
| coms: Commands to append. |
There was a problem hiding this comment.
Suggested change
| Args: | |
| coms: Commands to append. | |
| Args: | |
| coms: Commands to append. | |
| Raises: | |
| IndexError: If any input index to a command is not a tracked wire. |
hugr-py/src/hugr/index_dfg.py
Outdated
Comment on lines
190
to
191
| Args: | ||
| *in_wires: Wires/indices to set as outputs. |
There was a problem hiding this comment.
Suggested change
| Args: | |
| *in_wires: Wires/indices to set as outputs. | |
| Args: | |
| *in_wires: Wires/indices to set as outputs. | |
| Raises: | |
| IndexError: If an index is not a tracked wire. |
get_wire -> tracked_wire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1242
More test ideas welcome!
BEGIN_COMMIT_OVERRIDE
feat(hugr-py):
TrackedDfgbuilder for appending operations by indexEND_COMMIT_OVERRIDE